CLN: Added static types #33126
Merged
CLN: Added static types #33126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/_libs/parsers.pyx
Outdated
| @@ -591,6 +579,9 @@ cdef class TextReader: | |||
| self.parser.quotechar = ord(quote_char) | |||
|
|
|||
| cdef _make_skiprow_set(self): | |||
| cdef: | |||
| int64_t i | |||
|
|
|||
| if isinstance(self.skiprows, (int, np.integer)): | |||
WillAyd
requested changes
Mar 30, 2020
pandas/_libs/parsers.pyx
Outdated
| @@ -591,6 +579,9 @@ cdef class TextReader: | |||
| self.parser.quotechar = ord(quote_char) | |||
|
|
|||
| cdef _make_skiprow_set(self): | |||
| cdef: | |||
| int64_t i | |||
There was a problem hiding this comment.
For anything that is used to index Python objects you should opt for Py_ssize_t
There was a problem hiding this comment.
I see, my reason to have this as int64_t is because below we have the line:
for i in self.skiprows:
parser_add_skiprow(self.parser, i)Which calls parser_add_skiprow, parser_add_skiprow is defined here:
pandas/pandas/_libs/parsers.pyx
Line 207 in 7673357
and i is in the place of row, I tried to match the type, to avoid (potential) casting.
There was a problem hiding this comment.
I think that should also be a Py_ssize_t; I don't know what effort it would require to update that but OK to split off on a separate PR too
added 4 commits
March 30, 2020 13:58
|
LGTM |
WillAyd
approved these changes
Mar 31, 2020
|
@jreback here as well; I think good to merge |
|
thanks @MomIsBestFriend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff